Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Expand iOS Presentation Methods #543

Merged
merged 21 commits into from
Aug 8, 2023

Conversation

dtroupe-plaid
Copy link
Collaborator

@dtroupe-plaid dtroupe-plaid commented Aug 7, 2023

Summary

Adds the ability for Link to be presented using UIModalPresentationOverFullScreen.

Motivation

Customer request.

📝 Checklist

  • I have performed a self-review of my own code.
  • I have optimized code readability (class/variable names, straight forward logic paths, short clarifying docs,...).

💚 Testing

  • I have manually tested my changes.

You will need to test the local changes using the example app.

  1. run yalc publish at the root of the project
  2. cd example
  3. run yalc add react-native-plaid-link-sdk
  4. npm install
  5. cd ios
  6. bundle install
  7. bundle exec pod install
  8. npx react-native start
  9. npx react-native run-ios
  10. See the example app present Link as a modal
  11. Change line 37 in PlaidEventContainser.tsx from iOSPresentationStyle: LinkIOSPresentationStyle.MODAL, to iOSPresentationStyle: LinkIOSPresentationStyle.FULL_SCREEN,.
  12. Launch link again and see it presented full screen.

Example:

RN-IOS-MODAL-FULLSCREEN.mov

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@dtroupe-plaid dtroupe-plaid changed the base branch from master to develop August 8, 2023 16:31
@dtroupe-plaid dtroupe-plaid merged commit f68b7ea into develop Aug 8, 2023
3 checks passed
@dtroupe-plaid dtroupe-plaid deleted the dt-expand-ios-presentation-methods branch August 8, 2023 23:40
This was referenced Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant